style(rubocop): Style/SelectByRegexp

This commit is contained in:
Adam Cooke
2024-02-12 09:55:18 +00:00
parent 157d11457c
commit 9ce28a427f
3 changed files with 6 additions and 14 deletions
+2 -2
View File
@@ -44,12 +44,12 @@ module HasDNSChecks
def check_spf_record
result = resolver.getresources(name, Resolv::DNS::Resource::IN::TXT)
spf_records = result.map(&:data).select { |d| d =~ /\Av=spf1/ }
spf_records = result.map(&:data).grep(/\Av=spf1/)
if spf_records.empty?
self.spf_status = "Missing"
self.spf_error = "No SPF record exists for this domain"
else
suitable_spf_records = spf_records.select { |d| d =~ /include:\s*#{Regexp.escape(Postal.config.dns.spf_include)}/ }
suitable_spf_records = spf_records.grep(/include:\s*#{Regexp.escape(Postal.config.dns.spf_include)}/)
if suitable_spf_records.empty?
self.spf_status = "Invalid"
self.spf_error = "An SPF record exists but it doesn't include #{Postal.config.dns.spf_include}"