style(rubocop): Lint/IneffectiveAccessModifier

app/models/ip_pool_rule.rb

@@ -68,7 +68,9 @@ class IPPoolRule < ApplicationRecord
     errors.add :ip_pool_id, "must belong to the organization"
   end
 
-  def self.address_matches?(condition, address)
+  class << self
+
+    def address_matches?(condition, address)
       address = Postal::Helpers.strip_name_from_address(address)
       if condition =~ /@/
         parts = address.split("@")
@@ -82,4 +84,6 @@ class IPPoolRule < ApplicationRecord
       end
     end
 
+  end
+
 end

app/models/route.rb

@@ -219,7 +219,9 @@ class Route < ApplicationRecord
     errors.add :base, "Additional routes are not permitted unless the primary route is an actual endpoint"
   end
 
-  def self.find_by_name_and_domain(name, domain)
+  class << self
+
+    def find_by_name_and_domain(name, domain)
       route = Route.includes(:domain).where(name: name, domains: { name: domain }).first
       if route.nil?
         route = Route.includes(:domain).where(name: "*", domains: { name: domain }).first
@@ -227,4 +229,6 @@ class Route < ApplicationRecord
       route
     end
 
+  end
+
 end

lib/postal/smtp_sender.rb

@@ -252,7 +252,9 @@ module Postal
       records.first&.address&.to_s&.downcase
     end
 
-    def self.ssl_context_with_verify
+    class << self
+
+      def ssl_context_with_verify
         @ssl_context_with_verify ||= begin
           c = OpenSSL::SSL::SSLContext.new
           c.verify_mode = OpenSSL::SSL::VERIFY_PEER
@@ -262,7 +264,7 @@ module Postal
         end
       end
 
-    def self.ssl_context_without_verify
+      def ssl_context_without_verify
         @ssl_context_without_verify ||= begin
           c = OpenSSL::SSL::SSLContext.new
           c.verify_mode = OpenSSL::SSL::VERIFY_NONE
@@ -270,11 +272,11 @@ module Postal
         end
       end
 
-    def self.default_helo_hostname
+      def default_helo_hostname
         Postal.config.dns.helo_hostname || Postal.config.dns.smtp_server_hostname || "localhost"
       end
 
-    def self.relay_hosts
+      def relay_hosts
         hosts = Postal.config.smtp_relays.map do |relay|
           next unless relay.hostname.present?
 
@@ -288,4 +290,6 @@ module Postal
       end
 
     end
+
+  end
 end

lib/postal/worker.rb

@@ -195,22 +195,26 @@ module Postal
       self.class.logger
     end
 
-    def self.logger
+    class << self
+
+      def logger
         Postal.logger_for(:worker)
       end
 
-    def self.job_channel
+      def job_channel
         @channel ||= Postal::RabbitMQ.create_channel
       end
 
-    def self.job_queue(name)
+      def job_queue(name)
         @job_queues ||= {}
         @job_queues[name] ||= job_channel.queue("deliver-jobs-#{name}", durable: true, arguments: { "x-message-ttl" => 60_000 })
       end
 
-    def self.local_ip?(ip)
+      def local_ip?(ip)
         !!(ip =~ /\A(127\.|fe80:|::)/)
       end
 
     end
+
+  end
 end