mirror of
https://github.com/postalserver/postal.git
synced 2026-10-18 18:26:06 +00:00
chore(deps): upgrade to Rails 7.2.3.2, Ruby 3.4.10 and latest gems
Upgrades Rails from 7.1.6 to 7.2.3.2, Ruby from 3.4.6 to 3.4.10, and brings the rest of the bundle up to date. Two things were broken by Rails 7.2 and are fixed here: * MigrationWaiter called `ActiveRecord::Base.connection.migration_context`, which moved to the connection pool in 7.2. This raised NoMethodError on boot for any deployment with `migration_waiter.enabled` set, and had no test covering it. * `config.action_dispatch.show_exceptions = false` was deprecated in 7.1 and removed in 7.2. Now `:none`. `json` is pinned to < 3. Active Support 7.2 passes `quirks_mode:` to both `JSON.generate` and `JSON.parse`, and json 3.0 removed that option, so an unpinned json resolves to 3.x and makes every `to_json` raise - webhook payloads included. Nothing else in the bundle constrains it. The pin can go when we reach Rails 8.1, which no longer passes the option. `dynamic_form` is dropped. It is unmaintained and from 1.3.1 requires Ruby < 3.4, so it could never be updated again. Ten views used it, so `error_messages_for` now lives in ErrorMessagesHelper and `f.error_messages` in a form builder extension. The rendered markup is unchanged apart from a heading and description the stylesheet had always hidden; the rules that hid them are removed too. `execjs` is unpinned. The `< 2.8` constraint dated from the Rails 6.0 upgrade and asset output is byte-identical without it. Notable gem majors: puma 8, haml 7, secure_headers 7, sentry 7, jwt 3, prometheus-client 5, highline 3, omniauth-rails_csrf_protection 2, rspec-rails 8, shoulda-matchers 8, rubocop 1.91. secure_headers 7 changes X-XSS-Protection from "1; mode=block" to "0", which is the correct modern default and matches Rails' own. `config.load_defaults` deliberately stays at 7.0. The pending 7.1 and 7.2 options are listed, commented out, in new_framework_defaults_7_1.rb and _7_2.rb so they can be adopted in stages - several change the signed cookie and cache formats and need a staged deploy. The vestigial new_framework_defaults_7_0.rb is removed, as `load_defaults 7.0` already applies all of it. Adds tests for the areas this touched, which were mostly uncovered: MigrationWaiter, the serialized columns that gate a defaults bump, JSON encoding, HAML template compilation for all 103 templates, page rendering, form error rendering and security headers. The assets Gemfile group now includes :test so the view layer can be exercised at all.
This commit is contained in:
@@ -0,0 +1,46 @@
|
||||
# frozen_string_literal: true
|
||||
|
||||
require "rails_helper"
|
||||
require "haml"
|
||||
|
||||
# Compiles every HAML template and checks the Ruby it produces actually parses.
|
||||
# A HAML major version bump changes the compiler, and the request specs only
|
||||
# render a handful of pages, so without this most of app/views is unverified
|
||||
# until someone visits the page in production.
|
||||
RSpec.describe "HAML templates" do
|
||||
def compile(source)
|
||||
# Wrapped in a method body because layouts use `yield`, which is not legal
|
||||
# at the top level.
|
||||
RubyVM::AbstractSyntaxTree.parse("def _template\n#{Haml::Engine.new.call(source)}\nend")
|
||||
end
|
||||
|
||||
templates = Dir[Rails.root.join("app/views/**/*.haml")]
|
||||
|
||||
it "finds the templates to check" do
|
||||
expect(templates.size).to be > 50
|
||||
end
|
||||
|
||||
# Without this, a change in how HAML reports errors could quietly turn every
|
||||
# example below into a no-op that passes on anything.
|
||||
describe "the check itself" do
|
||||
it "rejects a template whose Ruby does not parse" do
|
||||
expect { compile("= foo(\n") }.to raise_error(SyntaxError)
|
||||
end
|
||||
|
||||
it "rejects a template with a malformed attribute hash" do
|
||||
expect { compile("%div{:a =>}\n") }.to raise_error(SyntaxError)
|
||||
end
|
||||
|
||||
it "accepts a valid template" do
|
||||
expect { compile("%div\n %p hello\n") }.to_not raise_error
|
||||
end
|
||||
end
|
||||
|
||||
templates.each do |path|
|
||||
relative = path.sub("#{Rails.root}/", "")
|
||||
|
||||
it "compiles #{relative}" do
|
||||
expect { compile(File.read(path)) }.to_not raise_error
|
||||
end
|
||||
end
|
||||
end
|
||||
Reference in New Issue
Block a user