refactor(versioning): improve how current version and branch is determined and set

Refactor `Postal.version`` and `Postal.branch` and remove `Postal::VERSION`.

Dockerfile

@@ -43,10 +43,10 @@ COPY ./docker/wait-for.sh /docker-entrypoint.sh
 COPY --chown=postal . .
 
 # Export the version
-ARG VERSION=null
+ARG VERSION
-ARG BRANCH=null
+ARG BRANCH
-RUN echo $VERSION > VERSION \
+RUN if [ "$VERSION" != "" ]; then echo $VERSION > VERSION; fi \
-  && echo $BRANCH > BRANCH
+  && if [ "$BRANCH" != "" ]; then echo $BRANCH > BRANCH; fi
 
 # Set paths for when running in a container
 ENV POSTAL_CONFIG_FILE_PATH=/config/postal.yml

lib/postal/config.rb

@@ -13,7 +13,6 @@ require "dotenv"
 require "klogger"
 
 require_relative "error"
-require_relative "version"
 require_relative "config_schema"
 require_relative "legacy_config_source"
 require_relative "signer"
@@ -131,7 +130,7 @@ module Postal
           notifier.notify!(short_message: short_message, **{
             facility: Config.gelf.facility,
             _environment: Config.rails.environment,
-            _version: Postal::VERSION.to_s,
+            _version: Postal.version.to_s,
             _group_ids: group_ids.join(" ")
           }.merge(payload.transform_keys { |k| "_#{k}".to_sym }.transform_values(&:to_s)))
         end
@@ -159,10 +158,26 @@ module Postal
     def branch
       return @branch if instance_variable_defined?("@branch")
 
-      @branch = begin
+      @branch ||= read_version_file("BRANCH")
-        path = Rails.root.join("BRANCH")
+    end
-        File.read(path).strip if File.exist?(path)
+
-      end
+    # Return the branch name which created this release
+    #
+    # @return [String, nil]
+    def version
+      return @version if instance_variable_defined?("@version")
+
+      @version ||= read_version_file("VERSION") || "0.0.0"
+    end
+
+    private
+
+    def read_version_file(file)
+      path = Rails.root.join(file)
+      return unless File.exist?(path)
+
+      value = File.read(path).strip
+      value.empty? ? nil : value
     end
 
   end

lib/postal/version.rb

@@ -1,18 +0,0 @@
-# frozen_string_literal: true
-
-module Postal
-
-  VERSION_PATH = File.expand_path("../../VERSION", __dir__)
-  if File.file?(VERSION_PATH)
-    VERSION = File.read(VERSION_PATH).strip.delete_prefix("v")
-  else
-    VERSION = "0.0.0-dev"
-  end
-
-  def self.version
-    VERSION
-  end
-
-  Version = VERSION
-
-end