From 08876b06fdeefeb6311c130d8695d67e34007d61 Mon Sep 17 00:00:00 2001 From: Khaled Mahfouz Date: Mon, 27 Apr 2026 00:12:17 +0300 Subject: [PATCH] Improve dependency setup feedback and fix Arabic locale YAML - Makefile: show go mod download progress (-x) and clearer install messaging. - README-en.md, README.md: update source-build Go requirement to 1.25+. - internal/i18n/locales/ar-SY.yml: quote %s-prefixed validation strings to fix YAML parsing on startup. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> >> FileTree Changes : modified: Makefile modified: README-en.md modified: README.md modified: internal/i18n/locales/ar-SY.yml --- Makefile | 9 +++++---- README-en.md | 2 +- README.md | 2 +- internal/i18n/locales/ar-SY.yml | 4 ++-- 4 files changed, 9 insertions(+), 8 deletions(-) diff --git a/Makefile b/Makefile index 1209bb5..b2764a2 100644 --- a/Makefile +++ b/Makefile @@ -5,6 +5,7 @@ BINARY_NAME := opengist GIT_TAG := $(shell git describe --tags) VERSION_PKG := github.com/thomiceli/opengist/internal/config.OpengistVersion TEST_DB_TYPE ?= sqlite +GO_MOD_DOWNLOAD_FLAGS ?= -x all: clean install build @@ -13,8 +14,8 @@ all_crosscompile: clean install build_frontend build_crosscompile install: @echo "Installing NPM dependencies..." @npm ci || (echo "Error: Failed to install NPM dependencies." && exit 1) - @echo "Installing Go dependencies..." - @go mod download || (echo "Error: Failed to install Go dependencies." && exit 1) + @echo "Installing Go dependencies (first run can take a while)..." + @go mod download $(GO_MOD_DOWNLOAD_FLAGS) || (echo "Error: Failed to install Go dependencies." && exit 1) build_frontend: @echo "Building frontend assets..." @@ -65,7 +66,7 @@ check_changes: @git --no-pager diff --exit-code || (echo "There are unstaged changes detected." && exit 1) go_mod: - @go mod download + @go mod download $(GO_MOD_DOWNLOAD_FLAGS) @go mod tidy fmt: @@ -75,4 +76,4 @@ test: @OPENGIST_TEST_DB=$(TEST_DB_TYPE) go test ./... -p 1 check-tr: - @bash ./scripts/check-translations.sh \ No newline at end of file + @bash ./scripts/check-translations.sh diff --git a/README-en.md b/README-en.md index c58d4ec..37667bb 100644 --- a/README-en.md +++ b/README-en.md @@ -89,7 +89,7 @@ Opengist is now running on port 6157, you can browse http://localhost:6157 ### From source -Requirements: [Git](https://git-scm.com/downloads) (2.28+), [Go](https://go.dev/doc/install) (1.23+), [Node.js](https://nodejs.org/en/download/) (16+), [Make](https://linux.die.net/man/1/make) (optional, but easier) +Requirements: [Git](https://git-scm.com/downloads) (2.28+), [Go](https://go.dev/doc/install) (1.25+), [Node.js](https://nodejs.org/en/download/) (16+), [Make](https://linux.die.net/man/1/make) (optional, but easier) ```shell git clone https://github.com/thomiceli/opengist diff --git a/README.md b/README.md index cab9c51..1bbf111 100644 --- a/README.md +++ b/README.md @@ -89,7 +89,7 @@ chmod +x opengist ### من المصدر -المتطلبات: [Git](https://git-scm.com/downloads) (2.28+)، [Go](https://go.dev/doc/install) (1.23+)، [Node.js](https://nodejs.org/en/download/) (16+)، [Make](https://linux.die.net/man/1/make) (اختياري لكنه أسهل) +المتطلبات: [Git](https://git-scm.com/downloads) (2.28+)، [Go](https://go.dev/doc/install) (1.25+)، [Node.js](https://nodejs.org/en/download/) (16+)، [Make](https://linux.die.net/man/1/make) (اختياري لكنه أسهل) ```shell git clone https://github.com/thomiceli/opengist diff --git a/internal/i18n/locales/ar-SY.yml b/internal/i18n/locales/ar-SY.yml index 54aeebc..60d1ad7 100644 --- a/internal/i18n/locales/ar-SY.yml +++ b/internal/i18n/locales/ar-SY.yml @@ -372,8 +372,8 @@ validation.should-not-be-empty: يجب ألا يكون الحقل %s فارغً validation.should-not-include-sub-directory: يجب ألا يتضمن الحقل %s مجلدًا فرعيًا validation.should-only-contain-alphanumeric-characters: يجب أن يحتوي الحقل %s على أحرف وأرقام فقط validation.should-only-contain-alphanumeric-characters-and-dashes: يجب أن يحتوي الحقل %s على أحرف وأرقام وشرطات فقط -validation.not-enough: %s غير كافٍ -validation.invalid: %s غير صالح +validation.not-enough: '%s غير كافٍ' +validation.invalid: '%s غير صالح' validation.invalid-gist-topics: مواضيع المقطع غير صالحة، يجب أن تبدأ بحرف أو رقم، وألا تتجاوز 50 حرفًا، ويمكن أن تتضمن شرطات html.title.admin-panel: لوحة الإدارة