From bb27d8c8a1703250a080caa0a182452aa4896783 Mon Sep 17 00:00:00 2001 From: Charlie Smurthwaite Date: Sat, 22 Jun 2019 09:26:20 +0100 Subject: [PATCH] Fix access to variable in check_dkim_record --- app/models/domain/dns_checks.rb | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/app/models/domain/dns_checks.rb b/app/models/domain/dns_checks.rb index 45c7452..de89b12 100644 --- a/app/models/domain/dns_checks.rb +++ b/app/models/domain/dns_checks.rb @@ -69,10 +69,6 @@ class Domain # DKIM # - def sanitised_dkim_record - return records.first.strip.ends_with?(';') ? records.first.strip : "#{records.first.strip};" - end - def check_dkim_record domain = "#{dkim_record_name}.#{name}" result = resolver.getresources(domain, Resolv::DNS::Resource::IN::TXT) @@ -81,6 +77,7 @@ class Domain self.dkim_status = 'Missing' self.dkim_error = "No TXT records were returned for #{domain}" else + sanitised_dkim_record = records.first.strip.ends_with?(';') ? records.first.strip : "#{records.first.strip};" if records.size > 1 self.dkim_status = 'Invalid' self.dkim_error = "There are #{records.size} records for at #{domain}. There should only be one."