From 9982bb8c31ee4885d188666e2e8afdc218528df7 Mon Sep 17 00:00:00 2001 From: Adam Cooke Date: Tue, 12 Mar 2024 20:54:40 +0000 Subject: [PATCH] fix(smtp-server): add additional information to cram-md5 log entries --- app/lib/smtp_server/client.rb | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/app/lib/smtp_server/client.rb b/app/lib/smtp_server/client.rb index bb6d03a..e38318e 100644 --- a/app/lib/smtp_server/client.rb +++ b/app/lib/smtp_server/client.rb @@ -252,7 +252,7 @@ module SMTPServer org_permlink, server_permalink = username.split(/[\/_]/, 2) server = ::Server.includes(:organization).where(organizations: { permalink: org_permlink }, permalink: server_permalink).first if server.nil? - logger&.warn "Authentication failure for #{@ip_address}" + logger&.warn "Authentication failure for #{@ip_address} (no server found matching #{username})" increment_error_count("invalid-credentials") next "535 Denied" end @@ -264,12 +264,13 @@ module SMTPServer @credential = credential @credential.use + logger&.debug "Authenticated with with credential #{credential.id}" grant = "235 Granted for #{credential.server.organization.permalink}/#{credential.server.permalink}" break end if grant.nil? - logger&.warn "Authentication failure for #{@ip_address}" + logger&.warn "Authentication failure for #{@ip_address} (invalid credential)" increment_error_count("invalid-credentials") next "535 Denied" end